Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #8378 parameter convert error for 3.0 #8414

Merged
merged 1 commit into from Aug 6, 2021
Merged

Conversation

24kpure
Copy link
Contributor

@24kpure 24kpure commented Aug 4, 2021

What is the purpose of the change

#8378

Brief changelog

Sevice and reference convert parameter in the same method,which is compatible with symbol(:) colon and and equal(=).As As for other config, like mock ,it works as well.

note

#8379 for 2.7.

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2021

Codecov Report

Merging #8414 (fa8726b) into 3.0 (63baa5c) will increase coverage by 0.04%.
The diff coverage is 92.30%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8414      +/-   ##
============================================
+ Coverage     63.21%   63.26%   +0.04%     
+ Complexity      312      311       -1     
============================================
  Files          1099     1099              
  Lines         46072    46074       +2     
  Branches       6958     6957       -1     
============================================
+ Hits          29126    29149      +23     
+ Misses        13688    13671      -17     
+ Partials       3258     3254       -4     
Impacted Files Coverage Δ
...dubbo/config/spring/util/DubboAnnotationUtils.java 48.27% <85.00%> (+19.32%) ⬆️
...ory/annotation/ServiceAnnotationPostProcessor.java 82.14% <100.00%> (+2.73%) ⬆️
.../config/spring/reference/ReferenceBeanSupport.java 94.40% <100.00%> (ø)
...ubbo/config/spring/reference/ReferenceCreator.java 69.04% <100.00%> (-0.81%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 67.48% <0.00%> (-0.99%) ⬇️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 45.32% <0.00%> (-0.99%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 79.00% <0.00%> (ø)
...he/dubbo/registry/multicast/MulticastRegistry.java 67.59% <0.00%> (+0.92%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63baa5c...fa8726b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants