Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the file parameter to MetadataReportBuilder #8031

Merged
merged 1 commit into from Jun 15, 2021
Merged

Add the file parameter to MetadataReportBuilder #8031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...g-api/src/main/java/org/apache/dubbo/config/bootstrap/builders/MetadataReportBuilder.java
View file
Open in desktop
Expand Up @@ -60,6 +60,11 @@ public class MetadataReportBuilder extends AbstractBuilder<MetadataReportConfig,
*/
private Boolean syncReport;

/**
* File for saving metadata center dynamic list
*/
private String file;

public static MetadataReportBuilder newBuilder() {
return new MetadataReportBuilder();
}
Expand Down Expand Up @@ -119,6 +124,11 @@ public MetadataReportBuilder syncReport(Boolean syncReport) {
return getThis();
}

public MetadataReportBuilder file(String file) {
this.file = file;
return getThis();
}

public MetadataReportConfig build() {
MetadataReportConfig metadataReport = new MetadataReportConfig();
super.build(metadataReport);
Expand All @@ -133,6 +143,7 @@ public MetadataReportConfig build() {
metadataReport.setRetryPeriod(retryPeriod);
metadataReport.setCycleReport(cycleReport);
metadataReport.setSyncReport(syncReport);
metadataReport.setFile(file);

return metadataReport;
}
Expand Down
10 changes: 9 additions & 1 deletion ...i/src/test/java/org/apache/dubbo/config/bootstrap/builders/MetadataReportBuilderTest.java
View file
Open in desktop
Expand Up @@ -123,11 +123,18 @@ void syncReport() {
Assertions.assertNull(builder.build().getSyncReport());
}

@Test
void file() {
MetadataReportBuilder builder = new MetadataReportBuilder();
builder.file("/tmp");
Assertions.assertEquals(builder.build().getFile(),"/tmp");
}

@Test
void build() {
MetadataReportBuilder builder = new MetadataReportBuilder();
builder.address("address").username("username").password("password").timeout(1000).group("group")
.retryTimes(1).retryPeriod(2).cycleReport(true).syncReport(false)
.retryTimes(1).retryPeriod(2).cycleReport(true).syncReport(false).file("file")
.appendParameter("default.num", "one").id("id").prefix("prefix");

MetadataReportConfig config = builder.build();
Expand All @@ -142,6 +149,7 @@ void build() {
Assertions.assertEquals("username", config.getUsername());
Assertions.assertEquals("password", config.getPassword());
Assertions.assertEquals("group", config.getGroup());
Assertions.assertEquals("file", config.getFile());
Assertions.assertTrue(config.getParameters().containsKey("default.num"));
Assertions.assertEquals("one", config.getParameters().get("default.num"));
Assertions.assertEquals("id", config.getId());
Expand Down