Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiMessageHandler should increase exception handling to prevent data loss #7816

Merged
merged 1 commit into from May 22, 2021

Conversation

xiaoheng1
Copy link
Contributor

What is the purpose of the change

MultiMessageHandler should increase exception handling to prevent data loss

see more detail from #7815

Brief changelog

Verifying this change

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2021

Codecov Report

Merging #7816 (b214bee) into master (1a7ca1e) will decrease coverage by 0.10%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7816      +/-   ##
============================================
- Coverage     59.47%   59.36%   -0.11%     
+ Complexity      556      555       -1     
============================================
  Files          1083     1086       +3     
  Lines         43755    43805      +50     
  Branches       6380     6391      +11     
============================================
- Hits          26022    26004      -18     
- Misses        14876    14920      +44     
- Partials       2857     2881      +24     
Impacted Files Coverage Δ Complexity Δ
.../dubbo/remoting/transport/MultiMessageHandler.java 80.00% <50.00%> (-20.00%) 0.00 <0.00> (ø)
...che/dubbo/remoting/transport/mina/MinaChannel.java 35.52% <0.00%> (-10.53%) 14.00% <0.00%> (-1.00%)
...ting/exchange/support/header/HeartbeatHandler.java 83.72% <0.00%> (-9.31%) 0.00% <0.00%> (ø%)
...va/org/apache/dubbo/rpc/support/ProtocolUtils.java 61.53% <0.00%> (-8.03%) 0.00% <0.00%> (ø%)
.../threadpool/manager/DefaultExecutorRepository.java 80.64% <0.00%> (-4.84%) 0.00% <0.00%> (ø%)
.../rpc/protocol/dubbo/LazyConnectExchangeClient.java 49.45% <0.00%> (-4.40%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/WrappedChannelHandler.java 58.69% <0.00%> (-4.35%) 0.00% <0.00%> (ø%)
...bo/registry/client/migration/MigrationInvoker.java 28.40% <0.00%> (-4.34%) 0.00% <0.00%> (ø%)
.../main/java/org/apache/dubbo/qos/server/Server.java 75.00% <0.00%> (-4.17%) 0.00% <0.00%> (ø%)
...e/dubbo/registry/integration/DynamicDirectory.java 74.25% <0.00%> (-3.97%) 0.00% <0.00%> (ø%)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a7ca1e...b214bee. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 22ec5a0 into apache:master May 22, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 28, 2021
vio-lin pushed a commit to vio-lin/incubator-dubbo that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants