Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the code for indicator monitoring #14106

Open
wants to merge 1 commit into
base: 3.3
Choose a base branch
from

Conversation

walklown
Copy link

What is the purpose of the change

[Task] Separate the code for indicator monitoring #14016

Brief changelog

1、Refer to Spring Event Multicaster, improve Dubbo Event Multicaster, and migrate to dubbo-common package.
2、Replace the MetricsEvent that occur in Dubbo with DubboEvent and broadcast them through Dubbo Event Multicaster. Remove the dependence on dubbo-metrics and only retain the dependence on dubbo-metrics-api. Please note that dubbo-plugin and dubbo-spring-boot still retain a dependency on dubbo-metrics-default because they require some advanced capabilities.
3、Split Collector and CollectorEventListener, and convert DubboEvent into MetricsEvent in CollectorEventListener.
4、Add the dubbo-metrics-starter package to listen to DubboEvent and initialize the metrics service at the appropriate time. Merge dubbo-metrics-event and dubbo-metrics-api into dubbo-metrics-core package, and only keep necessary interfaces and annotations in dubbo-metrics-api.

Verifying this change

Submitted DubboEventTest to test dubbo Dubbo Event Multicaster.
Passed all unit tests.

Copy link

sonarcloud bot commented Apr 21, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.16%. Comparing base (a12975a) to head (daf8165).
Report is 27 commits behind head on 3.3.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.3   #14106      +/-   ##
==========================================
- Coverage   38.55%   38.16%   -0.39%     
==========================================
  Files        1895     1915      +20     
  Lines       79272    79546     +274     
  Branches    11528    11540      +12     
==========================================
- Hits        30560    30357     -203     
- Misses      44439    44957     +518     
+ Partials     4273     4232      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@walklown
Copy link
Author

@songxiaosheng PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants