Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix channel leakage in NettyConnectionClient.onConnected and onGoaway methods #14100

Merged

Conversation

hanpen24
Copy link
Contributor

What is the purpose of the change

fixe #14097
This commit addresses the issue of channel leakage in the onConnected and onGoaway methods of NettyConnectionClient.

Previously, channels were not properly closed when new channels were set or when the channels were marked as go away, leading to potential resource leaks.

Brief changelog

onConnected Method

  • Added a check to close the existing channel before setting a new one.

onGoaway Method

  • Modified to close the channel if it is still open before setting it to null.

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link

sonarcloud bot commented Apr 18, 2024

@hanpen24 hanpen24 marked this pull request as draft April 18, 2024 23:11
@hanpen24 hanpen24 marked this pull request as ready for review April 20, 2024 03:02
@AlbumenJ
Copy link
Member

AlbumenJ commented May 8, 2024

@icodening @EarthChen PTAL

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EarthChen EarthChen merged commit 9d659eb into apache:3.2 May 8, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants