New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: AbstractCacheManager destroy Framework's executorService when shutdown #14091
Open
Chenjp
wants to merge
14
commits into
apache:3.2
Choose a base branch
from
Chenjp:3.2-fix-disposable-issue-13615
base: 3.2
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+43
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce disposable resource register mechanism. Follows "who creates, who destroys" rule.
gen by mvn eclipse:eclipse
Chenjp
changed the title
AbstractCacheManager destroy fix #13615
Fix: AbstractCacheManager destroy Framework's executorService when shutdown
Apr 28, 2024
AlbumenJ
reviewed
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chickenlj PTAL
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce disposable resource register mechanism. Follows "who creates, who destroys" rule.
What is the purpose of the change
Protect framework-executor from being destroyed by AbstractCacheManager.
Brief changelog
Introduce disposable resource register mechanism, simplify disposable#destroy implementation.
Verifying this change
Checklist