Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete_rpc_rest #14084

Closed
wants to merge 8 commits into from
Closed

delete_rpc_rest #14084

wants to merge 8 commits into from

Conversation

wcy666103
Copy link

What is the purpose of the change

take apark of #14061

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@finefuture
Copy link
Contributor

Please resolve the conflicts.

@@ -1,406 +0,0 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were these unit tests removed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are either using the rest protocol or using the rest protocol-specific userservice definition

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove only the rest-related parts, do not delete the entire unit test class.

# Conflicts:
#	dubbo-distribution/dubbo-all-shaded/pom.xml
#	dubbo-distribution/dubbo-all/pom.xml
#	dubbo-distribution/dubbo-core-spi/pom.xml
Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wcy666103
Copy link
Author

Is there something wrong with ci? I think recent pr failed on that test @finefuture

@AlbumenJ
Copy link
Member

AlbumenJ commented May 8, 2024

Please follow up #14061. Seperated PR will cause compile issues.

@AlbumenJ AlbumenJ closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants