New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete_rpc_rest #14084
delete_rpc_rest #14084
Conversation
Please resolve the conflicts. |
@@ -1,406 +0,0 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why were these unit tests removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are either using the rest protocol or using the rest protocol-specific userservice definition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove only the rest-related parts, do not delete the entire unit test class.
# Conflicts: # dubbo-distribution/dubbo-all-shaded/pom.xml # dubbo-distribution/dubbo-all/pom.xml # dubbo-distribution/dubbo-core-spi/pom.xml
Quality Gate passedIssues Measures |
Is there something wrong with ci? I think recent pr failed on that test @finefuture |
Please follow up #14061. Seperated PR will cause compile issues. |
What is the purpose of the change
take apark of #14061
Brief changelog
Verifying this change
Checklist