Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TripleConfig to ConfigManager #14077

Open
wants to merge 7 commits into
base: 3.3
Choose a base branch
from

Conversation

finefuture
Copy link
Contributor

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@oxsean oxsean requested a review from AlbumenJ April 12, 2024 13:55
@oxsean
Copy link
Collaborator

oxsean commented Apr 23, 2024

@AlbumenJ Could you take a look add TripleConfig into configManager is reasonable?, or is there a better option?

@AlbumenJ
Copy link
Member

AlbumenJ commented May 8, 2024

Add a special protocol related config to ConfigManager is not a good idea. We need a more reasonable way to manage these special configs.

@finefuture
Copy link
Contributor Author

Add a special protocol related config to ConfigManager is not a good idea. We need a more reasonable way to manage these special configs.

How about putting it in ProtocolConfig as nest configuration?

Copy link

sonarcloud bot commented May 8, 2024

@AlbumenJ
Copy link
Member

AlbumenJ commented May 9, 2024

Add a special protocol related config to ConfigManager is not a good idea. We need a more reasonable way to manage these special configs.

How about putting it in ProtocolConfig as nest configuration?

  1. Still a little wired
  2. This will change the full key from dubbo.triple.xxx to dubbo.protocol.triple.xxx

@finefuture
Copy link
Contributor Author

Add a special protocol related config to ConfigManager is not a good idea. We need a more reasonable way to manage these special configs.

How about putting it in ProtocolConfig as nest configuration?

  1. Still a little wired
  2. This will change the full key from dubbo.triple.xxx to dubbo.protocol.triple.xxx

Do you have any ideas? I think the second point is acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants