Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:embedded-redis need update version to run on macos Sonoma #14074

Merged
merged 2 commits into from May 6, 2024

Conversation

Stellar1999
Copy link

What is the purpose of the change

refer: #14072

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@Stellar1999 Stellar1999 changed the title fix:embedded-redis need update version to run on macos Sonoma (#14072) fix:embedded-redis need update version to run on macos Sonoma Apr 12, 2024
Copy link

sonarcloud bot commented Apr 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@JavaLionLi
Copy link
Contributor

兄台 把jedis版本升一升呗 现在用的太低了

@Stellar1999
Copy link
Author

兄台 把jedis版本升一升呗 现在用的太低了

Why do we need to upgrade?

@JavaLionLi
Copy link
Contributor

兄台 把jedis版本升一升呗 现在用的太低了

Why do we need to upgrade?

因为性能和bug 新版本性能更好bug更少

@Stellar1999
Copy link
Author

Stellar1999 commented Apr 24, 2024

兄台 把jedis版本升一升呗 现在用的太低了

Why do we need to upgrade?

因为性能和bug 新版本性能更好bug更少

I understand your point, but I believe if there are no actual bugs or security issues, there's no need to update it. However, if you'd like to propose an upgrade, you can open another pull request to discuss it with the community. I think the committers or PMC would appreciate seeing these beneficial changes and review them.

@AlbumenJ
Copy link
Member

AlbumenJ commented May 6, 2024

@AlbumenJ AlbumenJ merged commit 10af737 into apache:3.3 May 6, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants