-
Notifications
You must be signed in to change notification settings - Fork 26.5k
Fix dubbo service name bug #11038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dubbo service name bug #11038
Conversation
This reverts commit 8b580d0.
execute(namingService -> { | ||
if (isServiceNamesWithCompatibleMode(url)) { | ||
List<Instance> allCorrespondingInstanceList = Lists.newArrayList(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove guava usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
Codecov Report
@@ Coverage Diff @@
## master #11038 +/- ##
============================================
+ Coverage 60.82% 60.87% +0.05%
Complexity 447 447
============================================
Files 1101 1100 -1
Lines 44542 44520 -22
Branches 6492 6488 -4
============================================
+ Hits 27092 27101 +9
+ Misses 14471 14449 -22
+ Partials 2979 2970 -9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of the change
for #10732
Brief changelog
Verifying this change
Checklist