Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10631 Fix PojoUtils support localdatetime,lcaldate,localtime serializable and deserialize #10632

Merged
merged 1 commit into from Sep 22, 2022

Conversation

wuwen5
Copy link
Contributor

@wuwen5 wuwen5 commented Sep 16, 2022

What is the purpose of the change

fixed #10631

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2022

Codecov Report

Merging #10632 (9923b2c) into master (bcf9764) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master   #10632   +/-   ##
=========================================
  Coverage     60.88%   60.88%           
+ Complexity      449      447    -2     
=========================================
  Files          1101     1101           
  Lines         44538    44542    +4     
  Branches       6490     6492    +2     
=========================================
+ Hits          27118    27121    +3     
- Misses        14448    14453    +5     
+ Partials       2972     2968    -4     
Impacted Files Coverage Δ
...apache/dubbo/common/utils/CompatibleTypeUtils.java 66.10% <100.00%> (+0.58%) ⬆️
.../java/org/apache/dubbo/common/utils/PojoUtils.java 73.31% <100.00%> (+0.12%) ⬆️
...che/dubbo/remoting/transport/mina/MinaChannel.java 35.52% <0.00%> (-10.53%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) ⬇️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 51.97% <0.00%> (-1.13%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 80.41% <0.00%> (+0.20%) ⬆️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 80.55% <0.00%> (+0.34%) ⬆️
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.58% <0.00%> (+0.58%) ⬆️
...pache/dubbo/registry/support/AbstractRegistry.java 80.74% <0.00%> (+1.11%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ changed the base branch from master to 3.1 September 19, 2022 06:24
@AlbumenJ AlbumenJ changed the base branch from 3.1 to master September 19, 2022 06:24
@AlbumenJ
Copy link
Member

Please fix to 3.1 branch.

@wuwen5
Copy link
Contributor Author

wuwen5 commented Sep 19, 2022

Currently, this is based on the 2.7 branch modification, and I re initiated the PR #10638

@AlbumenJ AlbumenJ closed this Sep 19, 2022
@wuwen5
Copy link
Contributor Author

wuwen5 commented Sep 20, 2022

@AlbumenJ Version 2.7.x is still used in our production environment. Can we solve this issue in 2.7.x?

@AlbumenJ AlbumenJ reopened this Sep 21, 2022
@AlbumenJ
Copy link
Member

@AlbumenJ Version 2.7.x is still used in our production environment. Can we solve this issue in 2.7.x?

OK, I will merge it into 2.7.x. BTW, 2.7.x will not merge in any feature in the future and will be in EOF in the next several months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants