Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7] Fix Nacos aggregate listen #10467

Merged
merged 3 commits into from Aug 16, 2022
Merged

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022

Codecov Report

Merging #10467 (35b8bcb) into master (787d26d) will decrease coverage by 0.87%.
The diff coverage is 70.73%.

❗ Current head 35b8bcb differs from pull request most recent head a09c405. Consider uploading reports for the commit a09c405 to get more accurate results

@@             Coverage Diff              @@
##             master   #10467      +/-   ##
============================================
- Coverage     60.98%   60.10%   -0.88%     
  Complexity      448      448              
============================================
  Files          1100     1101       +1     
  Lines         44512    44534      +22     
  Branches       6486     6490       +4     
============================================
- Hits          27144    26767     -377     
- Misses        14412    14814     +402     
+ Partials       2956     2953       -3     
Impacted Files Coverage Δ
...e/dubbo/registry/nacos/NacosAggregateListener.java 58.82% <58.82%> (ø)
...org/apache/dubbo/registry/nacos/NacosRegistry.java 55.30% <79.16%> (+0.09%) ⬆️
...gcenter/wrapper/CompositeDynamicConfiguration.java 0.00% <0.00%> (-66.67%) ⬇️
...ookeeper/ZookeeperDynamicConfigurationFactory.java 0.00% <0.00%> (-66.67%) ⬇️
...fig/configcenter/TreePathDynamicConfiguration.java 25.71% <0.00%> (-60.01%) ⬇️
...pport/zookeeper/ZookeeperDynamicConfiguration.java 0.00% <0.00%> (-60.00%) ⬇️
...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java 29.23% <0.00%> (-49.24%) ⬇️
.../dubbo/metadata/report/MetadataReportInstance.java 12.50% <0.00%> (-40.63%) ⬇️
...va/org/apache/dubbo/rpc/support/AccessLogData.java 53.16% <0.00%> (-37.98%) ⬇️
.../configcenter/support/zookeeper/CacheListener.java 0.00% <0.00%> (-32.44%) ⬇️
... and 49 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants