Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interrupt thread when InterruptedException occur #10299

Merged
merged 1 commit into from Jul 11, 2022
Merged

interrupt thread when InterruptedException occur #10299

merged 1 commit into from Jul 11, 2022

Conversation

happytimor
Copy link
Contributor

What is the purpose of the change

same with #10164

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022

Codecov Report

Merging #10299 (8398d79) into 3.0 (5f35f0d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.0   #10299      +/-   ##
============================================
- Coverage     65.69%   65.68%   -0.01%     
+ Complexity      319      318       -1     
============================================
  Files          1233     1233              
  Lines         53714    53715       +1     
  Branches       8111     8111              
============================================
- Hits          35288    35285       -3     
- Misses        14590    14599       +9     
+ Partials       3836     3831       -5     
Impacted Files Coverage Δ
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 70.64% <100.00%> (+3.04%) ⬆️
.../apache/dubbo/rpc/filter/ProfilerServerFilter.java 62.85% <0.00%> (-20.00%) ⬇️
.../remoting/transport/netty4/NettyServerHandler.java 62.79% <0.00%> (-9.31%) ⬇️
...e/dubbo/rpc/protocol/tri/transport/WriteQueue.java 73.80% <0.00%> (-4.77%) ⬇️
.../apache/dubbo/rpc/protocol/injvm/InjvmInvoker.java 63.56% <0.00%> (-3.88%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) ⬇️
...bo/rpc/protocol/dubbo/DecodeableRpcInvocation.java 74.03% <0.00%> (-2.89%) ⬇️
...bo/registry/support/CacheableFailbackRegistry.java 77.97% <0.00%> (-1.20%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 70.74% <0.00%> (-0.88%) ⬇️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 85.56% <0.00%> (+0.34%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f35f0d...8398d79. Read the comment docs.

@CrazyHZM CrazyHZM merged commit 303cd69 into apache:3.0 Jul 11, 2022
@AlbumenJ AlbumenJ added this to the 3.0.10 milestone Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants