New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the problem that the service was offline for a long time without re-registration #10182
Conversation
private static final ExecutorService CURATOR_WATCHER_EXECUTOR_SERVICE = Executors.newSingleThreadExecutor(new ThreadFactory() { | ||
@Override | ||
public Thread newThread(Runnable r) { | ||
Thread thread = new Thread(r); | ||
thread.setName("Dubbo-CuratorWatcher-Thread"); | ||
return thread; | ||
} | ||
}); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace to use org.apache.dubbo.common.threadpool.manager.FrameworkExecutorRepository#getSharedExecutor
.
getUrl().getOrDefaultFrameworkModel().getBeanFactory()
.getBean(FrameworkExecutorRepository.class).getSharedExecutor();
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace to use
org.apache.dubbo.common.threadpool.manager.FrameworkExecutorRepository#getSharedExecutor
.getUrl().getOrDefaultFrameworkModel().getBeanFactory() .getBean(FrameworkExecutorRepository.class).getSharedExecutor();
The FrameworkExecutorRepository
class is available after 3.0
branch, but my code is master
branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get. Would you please submit a pr base on 3.0
branch after this pr merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Codecov Report
@@ Coverage Diff @@
## master #10182 +/- ##
============================================
+ Coverage 60.52% 60.88% +0.35%
- Complexity 412 448 +36
============================================
Files 1100 1100
Lines 44569 44579 +10
Branches 6492 6492
============================================
+ Hits 26976 27141 +165
+ Misses 14624 14462 -162
- Partials 2969 2976 +7
Continue to review full report at Codecov.
|
What is the purpose of the change
fix bug #10181
Brief changelog
make
EventThread
non-blocking to fix bug #10181Checklist