Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Cherry pick #9978 to 3.0 #10040

Merged
merged 3 commits into from Jun 10, 2022
Merged

[3.0] Cherry pick #9978 to 3.0 #10040

merged 3 commits into from Jun 10, 2022

Conversation

wangchengming666
Copy link
Member

What is the purpose of the change

Cherry pick #9978 to 3.0

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2022

Codecov Report

Merging #10040 (ec68625) into 3.0 (7e8c7aa) will increase coverage by 0.07%.
The diff coverage is 25.00%.

@@             Coverage Diff              @@
##                3.0   #10040      +/-   ##
============================================
+ Coverage     65.75%   65.82%   +0.07%     
+ Complexity      320      297      -23     
============================================
  Files          1220     1220              
  Lines         53139    53137       -2     
  Branches       8056     8054       -2     
============================================
+ Hits          34939    34979      +40     
+ Misses        14394    14355      -39     
+ Partials       3806     3803       -3     
Impacted Files Coverage Δ
...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java 25.97% <25.00%> (+0.65%) ⬆️
...vent/listener/ServiceInstancesChangedListener.java 80.84% <0.00%> (+0.38%) ⬆️
...pache/dubbo/registry/support/AbstractRegistry.java 77.28% <0.00%> (+0.67%) ⬆️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 85.91% <0.00%> (+0.68%) ⬆️
...ting/zookeeper/curator/CuratorZookeeperClient.java 70.19% <0.00%> (+0.96%) ⬆️
...java/org/apache/dubbo/remoting/api/Connection.java 71.31% <0.00%> (+1.63%) ⬆️
...ubbo/registry/client/AbstractServiceDiscovery.java 85.12% <0.00%> (+1.65%) ⬆️
...exchange/support/header/HeaderExchangeHandler.java 62.83% <0.00%> (+1.76%) ⬆️
.../apache/dubbo/remoting/transport/CodecSupport.java 83.33% <0.00%> (+3.03%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e8c7aa...ec68625. Read the comment docs.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM/

@chickenlj chickenlj added this to the 3.0.9 milestone Jun 10, 2022
@chickenlj chickenlj merged commit 25d9daa into apache:3.0 Jun 10, 2022
@wangchengming666 wangchengming666 deleted the cherry-pick-#9978 branch June 12, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants