2.7.15 ZookeeperDynamicConfiguration移除Listener逻辑疑问 猜测是bug

[SZFHH]

• I have searched the issues of this repository and believe that this is not a duplicate.

Ask your question here

// ZookeeperDynamicConfiguration

@Override
protected void doRemoveListener(String pathKey, ConfigurationListener listener) {
    Set<ConfigurationListener> configurationListeners = cacheListener.getConfigurationListeners(pathKey);
    // 为什么要把整个cacheListener都删掉？
    if (CollectionUtils.isNotEmpty(configurationListeners)) {
        zkClient.removeDataListener(pathKey, cacheListener);
    }
    cacheListener.removeListener(pathKey, listener);
}

为什么删除pathKey中的一个ConfigurationListener要把整个cacheListener都删掉？这样不是相当于这个pathKey下所有的ConfigurationListener都失效了吗？

不知道是不是下面这个逻辑比较合理

@Override
protected void doRemoveListener(String pathKey, ConfigurationListener listener) {
    cacheListener.removeListener(pathKey, listener);
    Set<ConfigurationListener> configurationListeners = cacheListener.getConfigurationListeners(pathKey);
    if (CollectionUtils.isEmpty(configurationListeners)) {
        zkClient.removeDataListener(pathKey, cacheListener);
    }
}

[wangchengming666]

yes, you are right, i will fix it.

[CrazyHZM]

Resolved in #10106