fix #10059, fix ZookeeperDynamicConfiguration remove cache listener m…

…istake (#10106) Co-authored-by: 呈铭 <beck.wcm@antgroup.com>
apache · Jun 6, 2022 · edd3d28 · edd3d28
1 parent c25284e
commit edd3d28
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...n/java/org/apache/dubbo/configcenter/support/zookeeper/ZookeeperDynamicConfiguration.java b/...n/java/org/apache/dubbo/configcenter/support/zookeeper/ZookeeperDynamicConfiguration.java
@@ -121,10 +121,10 @@ protected void doAddListener(String pathKey, ConfigurationListener listener) {
 
     @Override
     protected void doRemoveListener(String pathKey, ConfigurationListener listener) {
+        cacheListener.removeListener(pathKey, listener);
         Set<ConfigurationListener> configurationListeners = cacheListener.getConfigurationListeners(pathKey);
-        if (CollectionUtils.isNotEmpty(configurationListeners)) {
+        if (CollectionUtils.isEmpty(configurationListeners)) {
             zkClient.removeDataListener(pathKey, cacheListener);
         }
-        cacheListener.removeListener(pathKey, listener);
     }
 }