Optimize URL#addParameters method to reuse existing methods (#8005)

apache · Jun 8, 2021 · ed88f43 · ed88f43
1 parent ab4de5c
commit ed88f43
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/URL.java b/dubbo-common/src/main/java/org/apache/dubbo/common/URL.java
@@ -1244,18 +1244,10 @@ public URL addParametersIfAbsent(Map<String, String> parameters) {
     }
 
     public URL addParameters(String... pairs) {
-        if (pairs == null || pairs.length == 0) {
+        if (ArrayUtils.isEmpty(pairs)) {
             return this;
         }
-        if (pairs.length % 2 != 0) {
-            throw new IllegalArgumentException("Map pairs can not be odd number.");
-        }
-        Map<String, String> map = new HashMap<>();
-        int len = pairs.length / 2;
-        for (int i = 0; i < len; i++) {
-            map.put(pairs[2 * i], pairs[2 * i + 1]);
-        }
-        return addParameters(map);
+        return addParameters(CollectionUtils.toStringMap(pairs));
     }
 
     public URL addParameterString(String query) {