Add the file parameter to MetadataReportBuilder (#8031)

apache · Jun 15, 2021 · ba4d88e · ba4d88e
1 parent 50d88d7
commit ba4d88e
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/...g-api/src/main/java/org/apache/dubbo/config/bootstrap/builders/MetadataReportBuilder.java b/...g-api/src/main/java/org/apache/dubbo/config/bootstrap/builders/MetadataReportBuilder.java
@@ -60,6 +60,11 @@ public class MetadataReportBuilder extends AbstractBuilder<MetadataReportConfig,
      */
     private Boolean syncReport;
 
+    /**
+     * File for saving metadata center dynamic list
+     */
+    private String file;
+
     public static MetadataReportBuilder newBuilder() {
         return new MetadataReportBuilder();
     }
@@ -119,6 +124,11 @@ public MetadataReportBuilder syncReport(Boolean syncReport) {
         return getThis();
     }
 
+    public MetadataReportBuilder file(String file) {
+        this.file = file;
+        return getThis();
+    }
+
     public MetadataReportConfig build() {
         MetadataReportConfig metadataReport = new MetadataReportConfig();
         super.build(metadataReport);
@@ -133,6 +143,7 @@ public MetadataReportConfig build() {
         metadataReport.setRetryPeriod(retryPeriod);
         metadataReport.setCycleReport(cycleReport);
         metadataReport.setSyncReport(syncReport);
+        metadataReport.setFile(file);
 
         return metadataReport;
     }

diff --git a/...i/src/test/java/org/apache/dubbo/config/bootstrap/builders/MetadataReportBuilderTest.java b/...i/src/test/java/org/apache/dubbo/config/bootstrap/builders/MetadataReportBuilderTest.java
@@ -123,11 +123,18 @@ void syncReport() {
         Assertions.assertNull(builder.build().getSyncReport());
     }
 
+    @Test
+    void file() {
+        MetadataReportBuilder builder = new MetadataReportBuilder();
+        builder.file("/tmp");
+        Assertions.assertEquals(builder.build().getFile(),"/tmp");
+    }
+
     @Test
     void build() {
         MetadataReportBuilder builder = new MetadataReportBuilder();
         builder.address("address").username("username").password("password").timeout(1000).group("group")
-                .retryTimes(1).retryPeriod(2).cycleReport(true).syncReport(false)
+                .retryTimes(1).retryPeriod(2).cycleReport(true).syncReport(false).file("file")
                 .appendParameter("default.num", "one").id("id").prefix("prefix");
 
         MetadataReportConfig config = builder.build();
@@ -142,6 +149,7 @@ void build() {
         Assertions.assertEquals("username", config.getUsername());
         Assertions.assertEquals("password", config.getPassword());
         Assertions.assertEquals("group", config.getGroup());
+        Assertions.assertEquals("file", config.getFile());
         Assertions.assertTrue(config.getParameters().containsKey("default.num"));
         Assertions.assertEquals("one", config.getParameters().get("default.num"));
         Assertions.assertEquals("id", config.getId());