Failed retries of failback should be judged first (#8715) (#8719)

apache · Sep 11, 2021 · a09cece · a09cece
1 parent b1ebfe8
commit a09cece
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/FailbackClusterInvoker.java b/dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/FailbackClusterInvoker.java
@@ -107,7 +107,9 @@ protected Result doInvoke(Invocation invocation, List<Invoker<T>> invokers, Load
         } catch (Throwable e) {
             logger.error("Failback to invoke method " + invocation.getMethodName() + ", wait for retry in background. Ignored exception: "
                     + e.getMessage() + ", ", e);
-            addFailed(loadbalance, invocation, invokers, invoker, consumerUrl);
+            if (retries > 0) {
+                addFailed(loadbalance, invocation, invokers, invoker, consumerUrl);
+            }
             return AsyncRpcResult.newDefaultAsyncResult(null, null, invocation); // ignore
         }
     }