add dubbo rest demo #822
Open
add dubbo rest demo #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's really exciting to see this feature is about to be ready. As for this demo, I suggest the following:
|
chickenlj
reviewed
Apr 13, 2023
| </profile> | ||
| </profiles> | ||
|
|
||
| </project> |
There was a problem hiding this comment.
The pom file should also be simple and clear for each separate demo, making sure only necessary dependencies are added for each demo.
By the way, the dependencies here should also be reorganized to only keep necessary ones.
https://github.com/apache/dubbo/blob/3.2/dubbo-rpc/dubbo-rpc-rest/pom.xml
AlbumenJ
requested changes
Sep 5, 2023
| <source.level>1.8</source.level> | ||
| <target.level>1.8</target.level> | ||
| <spring.version>4.3.29.RELEASE</spring.version> | ||
| <dubbo.version>3.2.0-beta.6</dubbo.version> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dubbo_rest_3.2_demo