Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static tag route Demo: can be used to reduce time to return by avoid service call accross the IDC. #695

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zhouyao1994
Copy link
Contributor

The project dubbo-samples-tagrouter change the rule by yml
There are some scenarios where you need to write tags directly on dubbo , i think may be can add this example in it.

This strategy can be used to reduce time to return by avoid service call accross the IDC.
This can be achieved by putting the same tag on the same IDC service

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if we design this demo in spring-boot style config.

@zhouyao1994
Copy link
Contributor Author

It would be better if we design this demo in spring-boot style config.

I agree,may be i can modify this,and pull request again.

@AlbumenJ
Copy link
Member

AlbumenJ commented Jan 5, 2023

image

Please fix failed test cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants