Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 356 that ref to wrong type of map for nil value #357

Merged
merged 3 commits into from
Apr 9, 2023

Conversation

tiltwind
Copy link
Contributor

@tiltwind tiltwind commented Apr 6, 2023

What this PR does:

fix issue #356 that ref to wrong type of map for nil value

Which issue(s) this PR fixes:
Fixes #356

Special notes for your reviewer:
None

Does this PR introduce a user-facing change?:

fix issue #356 that ref to wrong type of map for nil value

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Merging #357 (f7ab7bd) into master (76ae75b) will decrease coverage by 0.03%.
The diff coverage is 90.00%.

❗ Current head f7ab7bd differs from pull request most recent head d1c8ccc. Consider uploading reports for the commit d1c8ccc to get more accurate results

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
- Coverage   72.18%   72.16%   -0.03%     
==========================================
  Files          27       27              
  Lines        3128     3129       +1     
==========================================
  Hits         2258     2258              
- Misses        633      634       +1     
  Partials      237      237              
Impacted Files Coverage Δ
ref.go 83.11% <88.88%> (-1.10%) ⬇️
map.go 59.58% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wenxuwan wenxuwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wongoo wongoo merged commit 33f7e9d into apache:master Apr 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

两个Map结构不同但值为nil时,decode will panic
6 participants