Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Add note about sqllogictest to contributor guide #4469

Merged
merged 2 commits into from Dec 2, 2022
Merged

MINOR: Add note about sqllogictest to contributor guide #4469

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
053e56c
docs: Add note about sqllogictest to contributor guide
alamb Dec 1, 2022
c37c6d3
Update docs/source/contributor-guide/index.md
alamb Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/source/contributor-guide/index.md
View file
Open in desktop
Expand Up @@ -134,6 +134,10 @@ cargo test -p datafusion --tests sql_integration

One very important test is the [sql_integration](../../../datafusion/core/tests/sql_integration.rs) test which validates DataFusion's ability to run a large assortment of SQL queries against an assortment of data setups.

### sqllogictests Tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding some comparison with Rust Integration Tests and encouraging adding logictestes as far as possible?


The [sqllogictests](../../../datafusion/core/tests/sqllogictests) also validate DataFusion SQL against an assortment of data setups.
alamb marked this conversation as resolved.
Show resolved Hide resolved

### SQL / Postgres Integration Tests

The [integration-tests](../../../integration-tests) directory contains a harness that runs certain queries against both postgres and datafusion and compares results
Expand Down