Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cli.md #4329

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Update cli.md #4329

merged 2 commits into from
Nov 23, 2022

Conversation

psvri
Copy link
Contributor

@psvri psvri commented Nov 22, 2022

Which issue does this PR close?

Closes #4239.

Rationale for this change

Updated S3 data source details in cli-usage docs.

What changes are included in this PR?

Updated the cli usage for S3 data source.

Are these changes tested?

NA

Are there any user-facing changes?

No

@psvri
Copy link
Contributor Author

psvri commented Nov 22, 2022

Any reason why * used for creating items in markdown is reported as an error in prettier ?

@alamb
Copy link
Contributor

alamb commented Nov 22, 2022

Any reason why * used for creating items in markdown is reported as an error in prettier ?

I don't know -- I simply run the command and check in the result

  npx prettier@2.7.1 --write \
    '{datafusion,datafusion-cli,datafusion-examples,dev,docs}/**/*.md' \
    '!datafusion/CHANGELOG.md' \
    README.md \
    CONTRIBUTING.md

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @psvri -- we just need to sort out the CI error as you point out and I think this one will be good to go

@psvri
Copy link
Contributor Author

psvri commented Nov 23, 2022

Thanks for sharing the commands.

Fixed the CI error in the recent commit.

@alamb alamb merged commit e817d75 into apache:master Nov 23, 2022
@alamb
Copy link
Contributor

alamb commented Nov 23, 2022

Thanks @psvri !

@ursabot
Copy link

ursabot commented Nov 23, 2022

Benchmark runs are scheduled for baseline = ad5a508 and contender = e817d75. e817d75 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@psvri psvri deleted the cli-usage-edits branch November 23, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot query s3 data from datafusion-cli
4 participants