New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse nanoseconds for intervals #4186
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -917,19 +917,19 @@ async fn test_interval_expressions() -> Result<()> { | |||||||||||||
); | ||||||||||||||
test_expression!( | ||||||||||||||
"interval '0.499 day'", | ||||||||||||||
"0 years 0 mons 0 days 11 hours 58 mins 33.596 secs" | ||||||||||||||
"0 years 0 mons 0 days 11 hours 58 mins 33.600 secs" | ||||||||||||||
); | ||||||||||||||
test_expression!( | ||||||||||||||
"interval '0.4999 day'", | ||||||||||||||
"0 years 0 mons 0 days 11 hours 59 mins 51.364 secs" | ||||||||||||||
"0 years 0 mons 0 days 11 hours 59 mins 51.360 secs" | ||||||||||||||
); | ||||||||||||||
test_expression!( | ||||||||||||||
"interval '0.49999 day'", | ||||||||||||||
"0 years 0 mons 0 days 11 hours 59 mins 59.136 secs" | ||||||||||||||
); | ||||||||||||||
test_expression!( | ||||||||||||||
"interval '0.49999999999 day'", | ||||||||||||||
"0 years 0 mons 0 days 12 hours 0 mins 0.00 secs" | ||||||||||||||
"0 years 0 mons 0 days 11 hours 59 mins 59.999999136 secs" | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great improvement! 👍 |
||||||||||||||
); | ||||||||||||||
test_expression!( | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i think we can add a test case for this (which will fail in the current version) and wait for the update to arrow 27 #4199
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i just found that the arrow-rs fix isn't included in 27.0.0 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can also add test cases that are marked as |
||||||||||||||
"interval '5 day'", | ||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍