Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multicolumn parquet predicate pushdown (#4046) #4048

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #4046

Rationale for this change

The first incarnation of this in #4021 computed the mapping from the projected schema to the file schema and not the other way round. For the case of two columns these are always the same thing and so it worked for the two column case, but more columns requires additional shenanigans.

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the core Core datafusion crate label Oct 31, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tustvold

This is all so familiar -- we have very similar logic in IOx in https://github.com/influxdata/influxdb_iox/blob/main/schema/src/sort.rs (though I don't see any obvious way to reuse it)

@@ -278,6 +274,32 @@ impl<'a> ExprRewriter for FilterCandidateBuilder<'a> {
}
}

/// Computes the projection required to go from the file's schema order to the projected
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these comments

@alamb
Copy link
Contributor

alamb commented Nov 1, 2022

I verified this fixes the issue in my test harness in #3976 -- given this is a non controversial bug fix I am merging it in now to keep that project chugging along

@alamb alamb merged commit ea31da9 into apache:master Nov 1, 2022
@ursabot
Copy link

ursabot commented Nov 1, 2022

Benchmark runs are scheduled for baseline = c92a38f and contender = ea31da9. ea31da9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Dandandan pushed a commit to yuuch/arrow-datafusion that referenced this pull request Nov 5, 2022
* Fix multicolumn parquet predicate pushdown (apache#4046)

* Format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Another Internal error when parquet predicate pushdown is enabled "Error evaluating filter predicate:
3 participants