Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: use DataType::is_nested #3995

Merged
merged 1 commit into from Oct 31, 2022
Merged

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Oct 28, 2022

Which issue does this PR close?

N/A

Rationale for this change

Use upstream code that @kfastov (馃憢 ) added in apache/arrow-rs#2704 rather than custom code in DataFusion

What changes are included in this PR?

Use DataType::is_nested

Are there any user-facing changes?

No

@alamb alamb changed the title Minor: use DataType::is_nested Minor: use DataType::is_nested Oct 28, 2022
@github-actions github-actions bot added the core Core datafusion crate label Oct 28, 2022
@alamb alamb merged commit a1c1cd2 into apache:master Oct 31, 2022
@ursabot
Copy link

ursabot commented Oct 31, 2022

Benchmark runs are scheduled for baseline = 22dea55 and contender = a1c1cd2. a1c1cd2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped 鈿狅笍 Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped 鈿狅笍 Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped 鈿狅笍 Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped 鈿狅笍 Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Dandandan pushed a commit to yuuch/arrow-datafusion that referenced this pull request Nov 5, 2022
@alamb alamb deleted the alamb/upstream_duplication branch August 8, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants