Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Parquet Row and Page Filtering by default (WIP) #3828

Closed
wants to merge 2 commits into from
Closed

Enable Parquet Row and Page Filtering by default (WIP) #3828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c249b07
Enable row pushdown and predicate reordering by default
alamb Oct 13, 2022
65ea1c2
fix compilation
alamb Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions datafusion/core/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,20 +240,20 @@ impl BuiltInConfigs {
OPT_PARQUET_PUSHDOWN_FILTERS,
"If true, filter expressions are be applied during the parquet decoding operation to \
reduce the number of rows decoded.",
false,
true,
),
ConfigDefinition::new_bool(
OPT_PARQUET_REORDER_FILTERS,
"If true, filter expressions evaluated during the parquet decoding opearation \
will be reordered heuristically to minimize the cost of evaluation. If false, \
the filters are applied in the same order as written in the query.",
false,
true,
),
ConfigDefinition::new_bool(
OPT_PARQUET_ENABLE_PAGE_INDEX,
"If true, uses parquet data page level metadata (Page Index) statistics \
to reduce the number of rows decoded.",
false,
true,
),
ConfigDefinition::new_bool(
OPT_OPTIMIZER_SKIP_FAILED_RULES,
Expand Down
10 changes: 3 additions & 7 deletions datafusion/core/src/physical_plan/file_format/parquet.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,13 +817,9 @@ mod tests {
},
predicate,
None,
);

if pushdown_predicate {
parquet_exec = parquet_exec
.with_pushdown_filters(true)
.with_reorder_filters(true);
}
)
.with_pushdown_filters(pushdown_predicate)
.with_reorder_filters(pushdown_predicate);

if page_index_predicate {
parquet_exec = parquet_exec.with_enable_page_index(true);
Expand Down