Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sqlparser to 0.24.0 #3675

Merged
merged 2 commits into from Oct 3, 2022
Merged

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Oct 1, 2022

Which issue does this PR close?

Re #3606

(based off dependabot #3654)

Rationale for this change

Upgrade to get support for explain plan format (e.g. explain graphviz)

What changes are included in this PR?

  1. Upgrade dependency
  2. Update code to use new code

Are there any user-facing changes?

No

dependabot bot and others added 2 commits September 29, 2022 08:32
Updates the requirements on [sqlparser](https://github.com/sqlparser-rs/sqlparser-rs) to permit the latest version.
- [Release notes](https://github.com/sqlparser-rs/sqlparser-rs/releases)
- [Changelog](https://github.com/sqlparser-rs/sqlparser-rs/blob/main/CHANGELOG.md)
- [Commits](sqlparser-rs/sqlparser-rs@v0.23.0...v0.24.0)

---
updated-dependencies:
- dependency-name: sqlparser
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@github-actions github-actions bot added core Core datafusion crate logical-expr Logical plan and expressions sql labels Oct 1, 2022
@@ -152,6 +152,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
verbose,
statement,
analyze,
format: _,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is the support for explain plan format

SQLExpr::Value(Value::Interval {
SQLExpr::Array(arr) => self.sql_array_literal(arr.elem, schema),

SQLExpr::Interval {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intervals are no longer literals (Value) but can have exprs so the AST was updated to match in sqlparser-rs/sqlparser-rs#609

@alamb alamb requested a review from Dandandan October 1, 2022 11:18
@xudong963
Copy link
Member

https://github.com/apache/arrow-datafusion/actions/runs/3164334070/jobs/5152557761

Other PRs also encountered the issue :/

@alamb
Copy link
Contributor Author

alamb commented Oct 1, 2022

https://github.com/apache/arrow-datafusion/actions/runs/3164334070/jobs/5152557761

Other PRs also encountered the issue :/

🤔 maybe we have hit the disk space limit on the github builders (14GB maybe?)

@alamb
Copy link
Contributor Author

alamb commented Oct 2, 2022

Filed #3678 for the CI failure

@alamb alamb merged commit f706902 into apache:master Oct 3, 2022
@ursabot
Copy link

ursabot commented Oct 3, 2022

Benchmark runs are scheduled for baseline = c9b26cc and contender = f706902. f706902 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core datafusion crate logical-expr Logical plan and expressions sql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants