New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sqlparser to 0.24.0 #3675
Conversation
Updates the requirements on [sqlparser](https://github.com/sqlparser-rs/sqlparser-rs) to permit the latest version. - [Release notes](https://github.com/sqlparser-rs/sqlparser-rs/releases) - [Changelog](https://github.com/sqlparser-rs/sqlparser-rs/blob/main/CHANGELOG.md) - [Commits](sqlparser-rs/sqlparser-rs@v0.23.0...v0.24.0) --- updated-dependencies: - dependency-name: sqlparser dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
@@ -152,6 +152,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { | |||
verbose, | |||
statement, | |||
analyze, | |||
format: _, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here is the support for explain plan format
SQLExpr::Value(Value::Interval { | ||
SQLExpr::Array(arr) => self.sql_array_literal(arr.elem, schema), | ||
|
||
SQLExpr::Interval { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intervals are no longer literals (Value
) but can have exprs so the AST was updated to match in sqlparser-rs/sqlparser-rs#609
https://github.com/apache/arrow-datafusion/actions/runs/3164334070/jobs/5152557761 Other PRs also encountered the issue :/ |
🤔 maybe we have hit the disk space limit on the github builders (14GB maybe?) |
Filed #3678 for the CI failure |
Benchmark runs are scheduled for baseline = c9b26cc and contender = f706902. f706902 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Re #3606
(based off dependabot #3654)
Rationale for this change
Upgrade to get support for explain plan format (e.g.
explain graphviz
)What changes are included in this PR?
Are there any user-facing changes?
No