Move decimal kernels to arrow-rs #3590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as it's not relevant to this draft PR functionality
github-actions
bot
added
core
|
cc @liukun4515 |
# Conflicts: # datafusion/common/Cargo.toml # datafusion/jit/Cargo.toml
|
I believe we're going to wait for the new and improved decimal implementation in arrow-rs, then switch DF over to that. This PR is no longer relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3521.
Closes #2259.
Rationale for this change
Removes the decimal arithmetic and comparison kernels that were moved to arrow-rs. The other half of this PR is in apache/arrow-rs#2770
This would remain in draft until Arrow 24 is released and DataFusion switches to that version.
What changes are included in this PR?
Are there any user-facing changes?