Update ahash requirement from 0.7 to 0.8
#3161
Conversation
Updates the requirements on [ahash](https://github.com/tkaitchuck/ahash) to permit the latest version. - [Release notes](https://github.com/tkaitchuck/ahash/releases) - [Commits](tkaitchuck/aHash@v0.7.6...v0.8.0) --- updated-dependencies: - dependency-name: ahash dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
github-actions
bot
added
core
| @@ -43,11 +43,11 @@ fn hash_null(random_state: &RandomState, hashes_buffer: &'_ mut [u64], mul_col: | |||
| if mul_col { | |||
| hashes_buffer.iter_mut().for_each(|hash| { | |||
| // stable hash for null value | |||
| *hash = combine_hashes(i128::get_hash(&1, random_state), *hash); | |||
| *hash = combine_hashes(random_state.hash_one(&1), *hash); | |||
There was a problem hiding this comment.
These changes are required due to tkaitchuck/aHash#121 which appears to have made CallHasher crate private
There was a problem hiding this comment.
Largely the same change @Dandandan applied in apache/arrow-rs#2410
Codecov Report
@@ Coverage Diff @@
## master #3161 +/- ##
=======================================
Coverage 85.87% 85.88%
=======================================
Files 291 291
Lines 52758 52758
=======================================
+ Hits 45307 45309 +2
+ Misses 7451 7449 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Benchmark runs are scheduled for baseline = 8ee31cc and contender = fbdb6f4. fbdb6f4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3094 (thanks @dependabot!)
Rationale for this change
Keep up with dependencies, ideally before 11.0.0 is released #3012
What changes are included in this PR?
0.8Are there any user-facing changes?
no