Support Time comparison #3158
Closed
Support Time comparison #3158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The relevant arrow feature has been released -- I wonder if this PR is still relevant? |
waitingkuo
force-pushed
the
time-comparison
branch
from
839b777
to
326085d
Compare
waitingkuo
force-pushed
the
time-comparison
branch
from
326085d
to
79f50a4
Compare
|
@alamb do you prefer to add these test cases? I could do the rebase and push again. Otherwise I think we could close the pr now as it's been solve. |
|
@alamb do you prefer to add these test cases? I could do the rebase and push again. Otherwise I think we could close the pr now as it's been solve. I think these tests would be very valuable as our sql coverage of time is pretty low at the moment. Perhaps you could make a |
|
i'll do it |
|
Closing as this PR is over a year old. Please feel free to reopen it / rebase it if you plan to keep working on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3157
Rationale for this change
i added some test cases in advance
This depends on apache/arrow-rs#2458
What changes are included in this PR?
Are there any user-facing changes?