to_timestamp align with postgresql #3000
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
|
pending due to #2998 . this make |
waitingkuo
force-pushed
the
to-timestamp-align-with-postgresql
branch
from
104558f
to
5447b0b
Compare
|
#2998 merged, test cases passed |
|
Closing as this PR is over a year old. Please feel free to reopen it / rebase it if you plan to keep working on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2979 .
Rationale for this change
original to_timestamp assume time unit is nanosecond. this pr is to change it to second based (to align with postgresql's to_timestamp)
What changes are included in this PR?
to_timestampuse seconds instead of nanoseconds. a newto_timestamp_nanosexpression is added that has the same behavior as the original to_timestampAre there any user-facing changes?
Yes. To migrate to new
to_timestamp. The original usage forto_timestamp(1_000_000_000)need to be modified to eitherto_timestamp(1)orto_timestamp_nanos(1_000_000_000)this pr has the breaking changes to puublic API:
to_timestamp