Upgrade to arrow 16.0.0
#2718
Merged
Upgrade to arrow 16.0.0
#2718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jun 10, 2022
| expected_error | ||
| ), | ||
| } | ||
| let e = execution_plan.unwrap_err().to_string(); |
There was a problem hiding this comment.
This is great -- arrow 16.0.0 contains support for casting Utf8 to bool (apache/arrow-rs#1738 - Thanks @MazterQyou) -- so I updated the test to try and cast Utf8 to some struct.
I also took the opportunity to clean up the test in general
alamb
commented
Jun 10, 2022
| Expr::Literal(ScalarValue::Utf8(Some("a".to_string()))), | ||
| Expr::Literal(ScalarValue::Int64(Some(1))), | ||
| ]; | ||
| let list = vec![lit("a"), lit(1i64)]; |
There was a problem hiding this comment.
used more concise construction of ScalarValues
github-actions
bot
added
logical-expr
alamb
commented
Jun 13, 2022
|
|
||
| Ok(()) | ||
| } | ||
|
|
||
| /// Return a `null` literal representing a struct type like: `{ a: bool }` | ||
| fn struct_literal() -> Expr { |
There was a problem hiding this comment.
Casting from Utf8 to Struct is still not supported
jimexist
approved these changes
Jun 14, 2022
andygrove
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft until arrow 16.0.0 is released
re: apache/arrow-rs#1809
This PR validates that DataFusion can be upgraded to the latest arrow
Closes #2732
Closes #2731
Closes #2733