Skip to content

Commit

Permalink
remove unecessary self parameter
Browse files Browse the repository at this point in the history
  • Loading branch information
alamb committed Nov 1, 2022
1 parent 287790f commit 3176d02
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
5 changes: 2 additions & 3 deletions datafusion/core/tests/parquet_filter_pushdown.rs
Original file line number Diff line number Diff line change
Expand Up @@ -399,9 +399,8 @@ impl TestCase {
assert_eq!(total_rows, self.expected_rows);

// verify expected pushdown
let metrics = test_file
.parquet_metrics(exec)
.expect("found parquet metrics");
let metrics =
TestParquetFile::parquet_metrics(exec).expect("found parquet metrics");
let pushdown_rows_filtered = get_value(&metrics, "pushdown_rows_filtered");
println!(" pushdown_rows_filtered: {}", pushdown_rows_filtered);

Expand Down
4 changes: 2 additions & 2 deletions parquet-test-utils/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -189,13 +189,13 @@ impl TestParquetFile {
///
/// Recursively searches for ParquetExec and returns the metrics
/// on the first one it finds
pub fn parquet_metrics(&self, plan: Arc<dyn ExecutionPlan>) -> Option<MetricsSet> {
pub fn parquet_metrics(plan: Arc<dyn ExecutionPlan>) -> Option<MetricsSet> {
if let Some(parquet) = plan.as_any().downcast_ref::<ParquetExec>() {
return parquet.metrics();
}

for child in plan.children() {
if let Some(metrics) = self.parquet_metrics(child) {
if let Some(metrics) = TestParquetFile::parquet_metrics(child) {
return Some(metrics);
}
}
Expand Down

0 comments on commit 3176d02

Please sign in to comment.