Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for S3 data sources #290

Merged
merged 10 commits into from Sep 29, 2022
Merged

Add support for S3 data sources #290

merged 10 commits into from Sep 29, 2022

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Sep 28, 2022

Which issue does this PR close?

Closes #10

Builds on #289

Rationale for this change

For users on AWS, Ballista is not an option unless it supports S3.

$ ./target/release/ballista-cli --host localhost --port 50050
Ballista CLI v0.8.0
❯ CREATE EXTERNAL TABLE test (a int, b int) STORED AS CSV LOCATION 's3://andygrove-benchmark-data/test.csv';
0 rows in set. Query took 0.000 seconds.
❯ select * from test;
+---+---+
| a | b |
+---+---+
| 1 | 2 |
+---+---+
1 row in set. Query took 0.716 seconds.

What changes are included in this PR?

Are there any user-facing changes?

No

@andygrove andygrove changed the title WIP: Add support for S3 data sources Add support for S3 data sources Sep 29, 2022
@andygrove andygrove marked this pull request as ready for review September 29, 2022 04:02
Copy link
Contributor

@yahoNanJing yahoNanJing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andygrove andygrove merged commit 1b29c02 into apache:master Sep 29, 2022
@avantgardnerio
Copy link
Contributor

Wow, thank you @andygrove , this makes my day considerably better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ballista does not support external file systems
3 participants