fix request dependency to ~2.81.0 to avoid later version which breaks… #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… upstream dependents
glynnbird
changed the title
|
For reference: request/request#2772 and request/request#2774 |
janl
approved these changes
Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently we depend on request version
^2.76.0. As of recent request releases, this is pulling in a faulty version of 'hawk' (https://github.com/request/request/blob/6f1b51ed43309128487739f20f9df0699a043124/package.json#L38).The quickest fix for this library is to lock the request dependency to
~2.81.0which prevent the faulty version of hawk being pulled in for Nano users and nodejs-cloudant users upstream.Testing recommendations
No code changes. Just dependency numbers.
Checklist