[CSV-63] CSVPrinter always quotes empty string if it is the first on a #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @tha2015 , this is a fix we would very much like to see. |
|
@tha2015 |
|
Is this still part of the main branch? 🤔 |
I don't understand the question. |
|
Could we merge the PR and bring the changes to the main branch? 🤔 |
|
is this going to be merged any time soon? |
|
This PR needs to be rebased on |
|
Sorry but I'm not working with it anymore. Please feel free to make changes or close it. |
|
Note: My local test on Windows shows that Excel consumes |
asfgit
pushed a commit
that referenced
this pull request
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified CSVPrinter.printRecords() methods and CSVFormat.printRecord() methods to handle first value of a record differently if it is an empty string and there are following values