Make the length check overflow safe.

apache · Dec 28, 2019 · 95bc7e1 · 95bc7e1
1 parent e4de423
commit 95bc7e1
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/main/java/org/apache/commons/codec/digest/MurmurHash3.java b/src/main/java/org/apache/commons/codec/digest/MurmurHash3.java
@@ -1030,8 +1030,9 @@ public final void add(final byte[] data, final int offset, final int length) {
             //                main block
             //                                remaining
 
-            // Check if the unprocessed bytes and new bytes can fill a block of 4
-            if (unprocessedLength + length < BLOCK_SIZE) {
+            // Check if the unprocessed bytes and new bytes can fill a block of 4.
+            // Make this overflow safe in the event that length is Integer.MAX_VALUE.
+            if (unprocessedLength + length - BLOCK_SIZE < 0) {
                 // Not enough so add to the unprocessed bytes
                 System.arraycopy(data, offset, unprocessed, unprocessedLength, length);
                 unprocessedLength += length;