New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove powermock from engine #7975
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7975 +/- ##
============================================
+ Coverage 29.16% 29.19% +0.03%
- Complexity 30383 30427 +44
============================================
Files 5100 5100
Lines 358291 358320 +29
Branches 52305 52308 +3
============================================
+ Hits 104510 104626 +116
+ Misses 239410 239322 -88
- Partials 14371 14372 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 44 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@blueorangutan package |
@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7062 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR removes powermock from tests in engine/ directory.
Didn't remove powermock from
ConfigDriveBuilderTest.java
because powermock is being used to mock File class which is not possible with Mockito as of now. Ref: mockito/mockito#1833Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?