Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove powermock from engine #7975

Merged
merged 3 commits into from Sep 20, 2023

Conversation

vishesh92
Copy link
Member

Description

This PR removes powermock from tests in engine/ directory.

Didn't remove powermock from ConfigDriveBuilderTest.java because powermock is being used to mock File class which is not possible with Mockito as of now. Ref: mockito/mockito#1833

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #7975 (5eb73a3) into main (c428d3b) will increase coverage by 0.03%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7975      +/-   ##
============================================
+ Coverage     29.16%   29.19%   +0.03%     
- Complexity    30383    30427      +44     
============================================
  Files          5100     5100              
  Lines        358291   358320      +29     
  Branches      52305    52308       +3     
============================================
+ Hits         104510   104626     +116     
+ Misses       239410   239322      -88     
- Partials      14371    14372       +1     
Flag Coverage Δ
simulator-marvin-tests 25.21% <ø> (+0.03%) ⬆️
uitests 4.87% <ø> (ø)
unit-tests 14.42% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...c/main/java/com/cloud/utils/db/GenericDaoBase.java 57.93% <ø> (+0.08%) ⬆️

... and 44 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vishesh92
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7062

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaanHoogland DaanHoogland merged commit 84277e7 into apache:main Sep 20, 2023
46 of 49 checks passed
@DaanHoogland DaanHoogland deleted the remove-powermock-engine branch September 20, 2023 08:11
@DaanHoogland DaanHoogland added this to the 4.19.0.0 milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants