refactor multiple publish-percentiles configuration to only one configuration. #1732
+25
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the PR 1689, I have added five publish-percentiles configuration, This PR changes all those five to only one configuration.
Motivation:
There are too many configurations for client SDK users to configure. Now I am think i added too many configurations and thought of changing to only one configuration.
Modifications:
change five publish-percentiles configuration to only one configuration.
Describe the modifications you've done.
Do appropriate changes in code to use only one publish-percentiles configuration.
Result:
We can control all the histogram metrics publish-percentiles through only configuration. We cannot have seprate percentiles for different histogram metrics.