Update pylint version once more on bst-1 branch
#1498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.gitlab-ci.yml: Remove deprecated F28 See merge request BuildStream/buildstream!1321
_artifactcache.py: display the actual key being pulled See merge request BuildStream/buildstream!1305
.gitlab-ci.yml: Add fedora 30 to coverage report See merge request BuildStream/buildstream!1326
If the artifact referred to by the last successful build in the workspace state no longer exists, reset the workspace state and do not attempt to perform an incremental build instead of crashing. This fixes #1017
…ith subdirs. The artifact directories are based on the element normal_name, which substitutes any path separators with dashes. Fix the helper function to use the correct path.
…ce artifacts are deleted This is a regression test for #1017
element.py: Reset workspace state if last successful build is missing (1.2) See merge request BuildStream/buildstream!1329
…esolved. When calculating the strict key, we do not know for sure yet that the element is required or whether it will ever have a cache key, as we could be tracking elements which will result in resolving an element which is a build-only dependency of the target. This ensures that we process all elements which need to be processed, which is important for cases where we are building in non-strict mode and tracking is also enabled. This fixes issue #1014
…r tracking This adds a check to test_build_track() to ensure that the target is cached as a result of building with tracking of selected elements.
… mode actually build This is a regression test for issue #1014
Fix build track all no strict 1.2 See merge request BuildStream/buildstream!1331
bst build returns "missing project.conf" when a project.conf is invalid This results in an existing project with malformed yaml being dismissed and attempts to make a new project Added new exception
Backport !792 to bst-1.2 See merge request BuildStream/buildstream!1338
…istency Instead of looping over the sources directly, we should be using the canonical way of checking element consistency. This requires an additional call to Element._update_state() on the freshly loaded junction element in order to ensure we calculate consistency. This fixes issue #1030.
…paced junctions We already test the behavior without workspaces, lets just augment these tests to also run with a workspaced junction and check the results. This guards against regressions of #1030.
Fix workspaced junctions (1.2) See merge request BuildStream/buildstream!1355
tests/artifactcache/expiry.py: Disable test failing on builders See merge request BuildStream/buildstream!1436
…cking This is better than raising a stack trace later on when logging gets intense with a BlockingIOError. This fixes #929
_frontend/cli.py: Exit with error if output streams are set to nonblocking See merge request BuildStream/buildstream!1389
This loads the configuration of the max-jobs variable from the user configuration, where the default is 0 (meaning use the maximum number of cores with a limit of 8). This is a part of #1033
While this is currently only relevant for `bst build`, it is
a current implementation detail that user configuration which
gets overridden by command line options must use toplevel
options.
This patch allows invocations such as the following to override
the max-jobs:
bst --max-jobs 16 build target.bst
This also updates the completions test to expect the new toplevel option.
This is a part of #1033
Only use automatic max-jobs by default if the user has not requested a specific value for max-jobs. This is a part of #1033
This tests that the resolution of the `max-jobs` automatic variable is properly controlled by the new user configuration and command line option, including the default automatic '0' value. Regression test for #1033
_context.py: Ensure paths in user configuration are absolute
Collections Abstract Base Classes has been moved to the collections.abc module See https://docs.python.org/3/library/collections.html#module-collections
bst-1: Use collections.abc instead collections
…systems This also removes the `pytest-pip8` and `pytest-pylint` pytest plugin dependencies, as we will be adopting the strategy from master and running the linter directly instead from now on. We now pin pylint at version 2.8.3, due to an upstream pylint crash introduced in 2.9.x, see: #1496 pylint-dev/pylint#4837
* Support testing of python 3.9
* Remove testing of python 3.5
* Separate pylint from setup.py, run it separately in tox
* Suppress some deprecation warnings and other warnings during tests
* Use --timeout=1800 pytest option to reduce the chance of blocking tests
* Added .github/run-ci.sh script to run CI locally
* Support only tox environments without coverage, as this is causing
hangs even in earlier versions of python now
To ensure we can run integration tests in parallel, use a tempdir for the artifact cache of each separate integration test run. This makes it possible to run multiple full test runs including integration tests in parallel under detox.
…I change We use some pytest internals in order to capture stdout and stderr separately when running tests, these internals have changed so we needed to adapt to that.
Since around the release of click 8.x, we have an API break in the click.Path() parameter type, where one of it's public members we were relying on has gone missing. See upstream report: pallets/click#2037 This was fairly easy to work around.
unused-private-member: currently raising a lot of false positives. chained-comparison: Encourages writing confusing statements
…vocations This helps pass tests on fedora 32.
On some platforms the path is too long to bind to a socket, in this case we just skip this file type.
…t our key We use some pre-generated gpg homedir data which we created on another platform and it is unclear whether the homedir is compatible across hosts and gpg versions. Our key is not recognized on centos 7, so we now just add a check and skip the test in the case that the key is not recognized.
Back in the days, git used to work very subtly differently than it does in these days... and the test for invalid-submodule warnings is reporting the inconsistent-submodule warnings instead. This is not significantly important enough to address in the bst-1 branch so we will just disable this invalid-submodule test in bst-1.
The --tags option before git 1.9.0 used to mean to fetch tags exclusively,
since git 1.9.0 the --tags option means to additionally fetch tags:
https://github.com/git/git/blob/master/Documentation/RelNotes/1.9.0.txt
This patch runs git fetch twice for older versions of git, which lets us
support centos 7.
Support python 3.9
with older version you will get errors like this accessing the CAS: [--:--:--][][] WARNING Failed to initialize remote https://freedesktop-sdk-cache.codethink.co.uk:11001: Received http2 header with status: 404
…m-version Update grpc minimum version to 1.30
This fixes #1496 by updating pylint to a version with the issue fixed, and also consequently updates ujson and ruamel.yaml.
gtristan
requested review from
BenjaminSchubert,
cs-shadow and
juergbi
as code owners
|
Are you sure this is right target branch? |
Oops thanks for pointing this out. I actually opened #1499 when I realized I had opened this PR against the wrong branch, and I couldn't find the "change base" feature (I just now discovered you can re-target the PR with a drop down menu when editing the PR)... it looks like I forgot to close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that upstream issue pylint-dev/pylint#4837 is fixed.