Bump coverage requirement to something >= 5.0 #1420
Conversation
Following https://coverage.readthedocs.io/en/coverage-5.0.4/changes.html#changes: - Only 5.0a2 pass all python3.8 tests - Multiprocessing support in Python 3.8 was fixed in 5.0a6
BuildStream-Migration-Bot
requested review from
BenjaminSchubert,
cs-shadow,
gtristan and
juergbi
as code owners
|
In GitLab by [Gitlab user @jjardon] on Apr 5, 2020, 11:19 changed the description |
|
In GitLab by [Gitlab user @jjardon] on Apr 5, 2020, 11:22 changed the description |
|
In GitLab by [Gitlab user @jjardon] on Apr 5, 2020, 11:23 changed the description |
|
In GitLab by [Gitlab user @jjardon] on Apr 5, 2020, 11:59 changed title from {-Update python dependencies-} to {+Bump coverage requirement to something >= 5.0+} |
|
In GitLab by [Gitlab user @jjardon] on Apr 5, 2020, 11:59 changed the description |
|
In GitLab by [Gitlab user @jjardon] on Apr 5, 2020, 12:00 added 1 commit
|
|
In GitLab by [Gitlab user @jjardon] on Apr 5, 2020, 13:28 added 1 commit
|
|
In GitLab by [Gitlab user @jjardon] on Apr 5, 2020, 13:30 added 1 commit
|
|
In GitLab by [Gitlab user @jjardon] on Apr 18, 2020, 18:17 added 53 commits |
|
In GitLab by [Gitlab user @cs-shadow] on Apr 21, 2020, 12:46 Commented on .gitlab-ci.yml line 97 the tests seem to be failing at the moment, but even if they pass, we shouldn't remove this entirely. The first comment about multiple python version still applies, however the second one won't (once the CI failures are fixed). This should become: # This particular testsuite image has both Python 3.7 and Python 3.8 so we
# need to explicitly force the 3.8 environment.
# Once Python 3.8 is available in distros, we should switch to such an
TOXENV: py38, py38-plugins |
|
In GitLab by [Gitlab user @tristanvb] on Nov 4, 2020, 07:28 Do I understand correctly that:
And that we just have to match the right version with the right target ? If this is a reality, then is it time to start creating python target version specific subdirectories in the |
|
In GitLab by [Gitlab user @BenjaminSchubert] on Nov 4, 2020, 09:25 I think we should postpone this. !1982 works with coverage 5+ apparently on python3.7, so I think we would be good with a single requirements file. |
|
Since we've been running without coverage report for the recent python versions, I think we should just swap the coverage report to work on recent versions and run 3.7 without coverage. This is what I did in #1590. |
See original merge request on GitLab
In GitLab by [Gitlab user @jjardon] on Apr 5, 2020, 11:14
From https://coverage.readthedocs.io/en/coverage-5.0.4/changes.html#changes:
Fixes #1173