WIP: [Go SDK] Handle PaneInfo correctly #31174
Conversation
| @@ -187,6 +187,30 @@ func reconcileCoders(bundle, base map[string]*pipepb.Coder) { | |||
| } | |||
| } | |||
|
|
|||
| func reconcileWindowCoders(bundle, base map[string]*pipepb.Coder, ws map[string]*pipepb.WindowingStrategy) { | |||
There was a problem hiding this comment.
I might open a separate PR for this, but without this, prism will error because the coder passed through the instruction is not included when there are multiple windowing strategies.
| @@ -26,3 +26,8 @@ func TestPanes(t *testing.T) { | |||
| integration.CheckFilters(t) | |||
| ptest.BuildAndRun(t, Panes) | |||
| } | |||
|
|
|||
| func TestPanesNonStreaming(t *testing.T) { | |||
There was a problem hiding this comment.
Just a drive-by: I'm uncertain how the different runners will treat panes in batch execution.
Triggers are more complicated than they appear, so thanks for giving this a go!
I know if they work, Flink will execute them correctly, regardless of Pipeline "mode" (batch or streaming), Dataflow might have different behavior for panes for Batch and Streaming pipelines.
Prism (the local runner), doesn't yet do anything with Panes, as it doesn't currently support triggers, which is the only material thing that mutates panes AFAICT.
My recommendation is making sure you get your expected behavior from Flink and Dataflow executions first, before trying to get Prism working (you might already be at this point, I see some changes to prism).
Do @mention me if you have questions!
WIP attempt to handle panes correctly.
TODO:
Fixes: #31153
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.