-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #22951 w/ GroupIntoBatchesOverride fix #24463
Conversation
…es size limit implementation.
Run Dataflow ValidatesRunner |
Run Dataflow Streaming ValidatesRunner |
Run Java Dataflow V2 ValidatesRunner |
Run Java Dataflow V2 ValidatesRunner Streaming |
CC: @nbali |
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
stop reviewer notifications |
Stopping reviewer notifications for this pull request: requested by reviewer |
Run Java PreCommit |
4 similar comments
Run Java PreCommit |
Run Java PreCommit |
Run Java PreCommit |
Run Java PreCommit |
* Fix for apache#22951 * Fix Dataflow GroupIntoBatchesOverride to match updated GroupIntoBatches size limit implementation. Co-authored-by: Balázs Németh <nbali@users.noreply.github.com>
* Fix for apache#22951 * Fix Dataflow GroupIntoBatchesOverride to match updated GroupIntoBatches size limit implementation. Co-authored-by: Balázs Németh <nbali@users.noreply.github.com>
Note that this is #22953 with a patch to fix the GroupIntoBatchesOverride implementation so that the Dataflow tests pass.
Closes #22951
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.