Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-13590]Update Pytest version to support Python 3.10 #17791

Merged
merged 2 commits into from Jun 21, 2022

Conversation

AnandInguva
Copy link
Contributor

@AnandInguva AnandInguva commented Jun 1, 2022

Update pytest dependencies to support Python 3.10


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented Jun 1, 2022

Can one of the admins verify this patch?

1 similar comment
@asf-ci
Copy link

asf-ci commented Jun 1, 2022

Can one of the admins verify this patch?

@github-actions github-actions bot added the python label Jun 1, 2022
@AnandInguva
Copy link
Contributor Author

R: @tvalentyn

@tvalentyn
Copy link
Contributor

Run Python PreCommit

@tvalentyn
Copy link
Contributor

Run Python 3.8 PostCommit

@AnandInguva
Copy link
Contributor Author

Run Python PreCommit

@tvalentyn
Copy link
Contributor

tvalentyn commented Jun 6, 2022

Took a quick look. please investigate if this is related to this change.

18:27:31 ================== 1 passed, 3 warnings in 683.71s (0:11:23) ===================
18:27:31 
18:27:31 > Task :sdks:python:test-suites:dataflow:preCommitIT_V2
18:27:31 
18:27:31 FAILURE: Build failed with an exception.
18:27:31 
18:27:31 * What went wrong:
18:27:31 Execution failed for task ':sdks:python:test-suites:tox:py38:testPy38CloudCoverage'.
18:27:31 > Process 'command 'sh'' finished with non-zero exit value 1
18:27:31 
18:27:31 * Try:
18:27:31 > Run with --stacktrace option to get the stack trace.
18:27:31 > Run with --info or --debug option to get more log output.
18:27:31 > Run with --scan to get full insights.
18:27:31 
18:27:31 * Get more help at https://help.gradle.org/
18:27:31 
18:27:31 Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

@AnandInguva
Copy link
Contributor Author

Took a quick look. please investigate if this is related to this change.

18:27:31 ================== 1 passed, 3 warnings in 683.71s (0:11:23) ===================
18:27:31 
18:27:31 > Task :sdks:python:test-suites:dataflow:preCommitIT_V2
18:27:31 
18:27:31 FAILURE: Build failed with an exception.
18:27:31 
18:27:31 * What went wrong:
18:27:31 Execution failed for task ':sdks:python:test-suites:tox:py38:testPy38CloudCoverage'.
18:27:31 > Process 'command 'sh'' finished with non-zero exit value 1
18:27:31 
18:27:31 * Try:
18:27:31 > Run with --stacktrace option to get the stack trace.
18:27:31 > Run with --info or --debug option to get more log output.
18:27:31 > Run with --scan to get full insights.
18:27:31 
18:27:31 * Get more help at https://help.gradle.org/
18:27:31 
18:27:31 Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

Yes. I will take a look

@AnandInguva
Copy link
Contributor Author

Run Python PreCommit

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #17791 (d4ba8d8) into master (9a6f769) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17791      +/-   ##
==========================================
- Coverage   74.02%   73.95%   -0.07%     
==========================================
  Files         695      700       +5     
  Lines       91872    92526     +654     
==========================================
+ Hits        68007    68428     +421     
- Misses      22619    22852     +233     
  Partials     1246     1246              
Flag Coverage Δ
python 83.57% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ache_beam/runners/dataflow/dataflow_job_service.py 50.00% <0.00%> (-12.17%) ⬇️
...s/interactive/dataproc/dataproc_cluster_manager.py 77.41% <0.00%> (-6.80%) ⬇️
...eam/transforms/py_dataflow_distribution_counter.py 91.42% <0.00%> (-4.87%) ⬇️
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
.../apache_beam/runners/interactive/dataproc/types.py 96.55% <0.00%> (-3.45%) ⬇️
sdks/python/apache_beam/dataframe/io.py 88.78% <0.00%> (-3.26%) ⬇️
...eam/runners/portability/fn_api_runner/fn_runner.py 87.51% <0.00%> (-2.50%) ⬇️
...nners/portability/fn_api_runner/worker_handlers.py 77.89% <0.00%> (-1.45%) ⬇️
sdks/python/apache_beam/io/source_test_utils.py 88.01% <0.00%> (-1.39%) ⬇️
sdks/python/apache_beam/utils/counters.py 85.39% <0.00%> (-1.36%) ⬇️
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a6f769...d4ba8d8. Read the comment docs.

@AnandInguva
Copy link
Contributor Author

Took a quick look. please investigate if this is related to this change.

18:27:31 ================== 1 passed, 3 warnings in 683.71s (0:11:23) ===================
18:27:31 
18:27:31 > Task :sdks:python:test-suites:dataflow:preCommitIT_V2
18:27:31 
18:27:31 FAILURE: Build failed with an exception.
18:27:31 
18:27:31 * What went wrong:
18:27:31 Execution failed for task ':sdks:python:test-suites:tox:py38:testPy38CloudCoverage'.
18:27:31 > Process 'command 'sh'' finished with non-zero exit value 1
18:27:31 
18:27:31 * Try:
18:27:31 > Run with --stacktrace option to get the stack trace.
18:27:31 > Run with --info or --debug option to get more log output.
18:27:31 > Run with --scan to get full insights.
18:27:31 
18:27:31 * Get more help at https://help.gradle.org/
18:27:31 
18:27:31 Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

I looked into it. pytest-cov needs to be updated as well because of pytest-dev/pytest-cov#412. Now everything passes.

PTAL @tvalentyn

@tvalentyn tvalentyn merged commit 75cba10 into apache:master Jun 21, 2022
ihji added a commit that referenced this pull request Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants