[BEAM-7746] Stop automatically creating staticmethods in register_urn

[chadrik]

It confuses pylint, mypy, PyCharm, and humans.

This is a followup to #9056.

R: @robertwb
R: @udim

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Choose reviewer(s) and mention them in a comment (R: @username).
• Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang	SDK	Apex	Dataflow	Flink	Gearpump	Samza	Spark
Go		---	---		---	---
Java
Python		---			---	---
XLang	---	---	---		---	---	---

Pre-Commit Tests Status (on master branch)

---	Java	Python	Go	Website
Non-portable
Portable	---		---	---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

[udim]

There's a @PTransform.register_urn in test_stream.py on a non-staticmember.

[chadrik]

Looks like the code changed a bit since I originally wrote this change. Will fix these and look for anything else I may have missed.

…

On Fri, Jan 17, 2020 at 4:15 PM Udi Meiri ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In sdks/python/apache_beam/coders/coders.py <#10594 (comment)>: > @@ -1014,6 +1015,7 @@ def to_runner_api_parameter(self, context): else: return super(TupleCoder, self).to_runner_api_parameter(context) + @staticmethod @Coder.register_urn(common_urns.coders.KV.urn, None) def from_runner_api_parameter(unused_payload, components, unused_context): return TupleCoder(components) Should ParamWindowedValueCoder.from_runner_api_parameter also get the @staticmethod decorator? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#10594?email_source=notifications&email_token=AAAPOE7G3EPNSYCU3G74NFLQ6JCZZA5CNFSM4KG3SOZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSHM7UA#pullrequestreview-344903632>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAPOE5XHZV7BVYNWGTKP2TQ6JCZZANCNFSM4KG3SOZA> .

[chadrik]

Chased down the newly added registration functions and added @staticmethod. I think this should be good to go now.