Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41717: [Java][Vector] fix issue with ByteBuffer rewind in MessageSerializer #41718

Merged
merged 5 commits into from
May 20, 2024

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented May 19, 2024

Rationale for this change

What changes are included in this PR?

#41717 describes issue and change

Are these changes tested?

CI build

Are there any user-facing changes?

@pjfanning pjfanning requested a review from lidavidm as a code owner May 19, 2024 09:40
Copy link

⚠️ GitHub issue #41717 has been automatically assigned in GitHub to PR creator.

@pjfanning pjfanning changed the title GH-41717: [JAVA] [VECTOR] fix issue with ByteBuffer rewind in MessageSerializer GH-41717: [Java][Vector] fix issue with ByteBuffer rewind in MessageSerializer May 19, 2024
@kou
Copy link
Member

kou commented May 19, 2024

@github-actions crossbow submit -g java

Copy link

module 'pygit2' has no attribute 'GIT_OBJ_COMMIT'
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/9150811236

@vibhatha
Copy link
Collaborator

@kou this error is not familiar. Could be a temporary issue?

@vibhatha
Copy link
Collaborator

@github-actions crossbow submit -g java

Copy link

module 'pygit2' has no attribute 'GIT_OBJ_COMMIT'
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/9151003846

@vibhatha
Copy link
Collaborator

cc @raulcd @assignUser any idea why the crossbow bot command is failing?

@assignUser
Copy link
Member

Uhh, looks like a new version of pygit? I'll have to check

@raulcd
Copy link
Member

raulcd commented May 19, 2024

Uhh, looks like a new version of pygit? I'll have to check

There was a release of pygit2 (1.15.0) yesterday so that checks. @vibhatha can you open an issue?

@raulcd
Copy link
Member

raulcd commented May 19, 2024

The error on the job can be seen here: https://github.com/apache/arrow/actions/runs/9150811236/job/25156057745#step:5:30

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels May 19, 2024
@pan3793
Copy link
Member

pan3793 commented May 20, 2024

What happened in 16.1.0, I got another similar error(in a different place)

java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer;
	at org.apache.arrow.memory.ArrowBuf.setBytes(ArrowBuf.java:907)
	at org.apache.arrow.vector.BaseVariableWidthVector.setSafe(BaseVariableWidthVector.java:1183)

@vibhatha
Copy link
Collaborator

@raulcd sorry about the delay.

Issue created here: #41735

@kou
Copy link
Member

kou commented May 20, 2024

@github-actions crossbow submit -g java

Copy link

Revision: f47bbcf

Submitted crossbow builds: ursacomputing/crossbow @ actions-3f91e4c81b

Task Status
java-jars GitHub Actions
test-conda-python-3.10-spark-v3.5.0 GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.8-spark-v3.5.0 GitHub Actions
verify-rc-source-java-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-java-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-java-macos-amd64 GitHub Actions

@lidavidm
Copy link
Member

Those failures are mostly expected. #41628 should help if I can get an actual review.

@lidavidm lidavidm merged commit 1cd2872 into apache:main May 20, 2024
14 of 16 checks passed
@lidavidm lidavidm removed the awaiting merge Awaiting merge label May 20, 2024
@vibhatha
Copy link
Collaborator

What happened in 16.1.0, I got another similar error(in a different place)

java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer;
	at org.apache.arrow.memory.ArrowBuf.setBytes(ArrowBuf.java:907)
	at org.apache.arrow.vector.BaseVariableWidthVector.setSafe(BaseVariableWidthVector.java:1183)

@pan3793 still facing this issue?

Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 1cd2872.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 29 possible false positives for unstable benchmarks that are known to sometimes produce them.

vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
…ssageSerializer (apache#41718)

### Rationale for this change

### What changes are included in this PR?

apache#41717 describes issue and change

### Are these changes tested?

CI build

### Are there any user-facing changes?

* GitHub Issue: apache#41717

Authored-by: PJ Fanning <pjfanning@users.noreply.github.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants