Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python][CI] Failing test_dateutil_tzinfo_to_string due to new release of python-dateutil #40626

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Mar 18, 2024

Rationale for this change

test_dateutil_tzinfo_to_string started failing with:

         tz = dateutil.tz.gettz('Europe/Paris')
>       assert pa.lib.tzinfo_to_string(tz) == 'Europe/Paris'
E       AssertionError: assert 'Europe/Monaco' == 'Europe/Paris'
E         - Europe/Paris
E         + Europe/Monaco

and it is most probably due to new release of python-dateutil package.

What changes are included in this PR?

Currently, we are using this PR to debug the test on Windows platform.

Are these changes tested?

A tests is failing and it needs to be fixed.

Are there any user-facing changes?

No.

Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@AlenkaF
Copy link
Member Author

AlenkaF commented Mar 18, 2024

We have assumed correctly there is an issue in python-dateutil:

_______________________ test_dateutil_tzinfo_to_string ________________________
    def test_dateutil_tzinfo_to_string():
        pytest.importorskip("dateutil")
        import dateutil.tz
    
        tz = dateutil.tz.UTC
        assert pa.lib.tzinfo_to_string(tz) == 'UTC'
        tz = dateutil.tz.gettz('Europe/Paris')
        print(tz)
>       assert pa.lib.tzinfo_to_string(tz) == 'Europe/Paris'
E       AssertionError: assert 'Europe/Monaco' == 'Europe/Paris'
E         - Europe/Paris
E         + Europe/Monaco
pyarrow\tests\test_types.py:356: AssertionError
---------------------------- Captured stdout call -----------------------------
tzfile('Europe/Monaco')
============================== warnings summary ===============================
pyarrow/tests/test_pandas.py::TestConvertMetadata::test_empty_list_metadata

Will report upstream.

@AlenkaF
Copy link
Member Author

AlenkaF commented Mar 18, 2024

Upstream issue: dateutil/dateutil#1353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant